Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid macos-latest Python version compatibility issues in GitHub Actions runner images #196

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Apr 23, 2024

Description

This PR addresses #195, enabling MacOS testing to take place. Based on a recent successful job run, I believe this is a major version jump from macos-12 to macos-13 in an effort to keep the declarative nature of this "more protected" from deprecations as they occur (for the time being).

If all looks good here, I plan to create an issue which helps us remember to update the MacOS version specification to a more compatible version when able or desired.

Closes #195
Required for #194 and other PR's in order to resolve GH Actions failures.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

.github/workflows/test.yml Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Apr 23, 2024

Thank you @gwaybio ! Merging this in.

@d33bs d33bs merged commit 2ab7502 into cytomining:main Apr 23, 2024
11 checks passed
@d33bs d33bs deleted the macos-python-versions-gh-actions branch April 23, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve MacOS Python setup issues within GitHub Actions after recent GitHub Update
2 participants